Fix pg_recvlogical not to fsync output when it's a tty or pipe.
authorAndres Freund
Tue, 7 Jul 2015 10:47:44 +0000 (12:47 +0200)
committerAndres Freund
Tue, 7 Jul 2015 11:07:50 +0000 (13:07 +0200)
commit1790b35baf52fff7f670f7cc1159a1b40b36e701
tree94b106e36abc8b7a091faf6d1a81dd53cca0f0cc
parent0471894a6f01007752abd37ca493ed371a720bdd
Fix pg_recvlogical not to fsync output when it's a tty or pipe.

The previous coding tried to handle possible failures when fsyncing a
tty or pipe fd by accepting EINVAL - but apparently some
platforms (windows, OSX) don't reliably return that. So instead check
whether the output fd refers to a pipe or a tty when opening it.

Reported-By: Olivier Gosseaume, Marko Tiikkaja
Discussion: 559AF98B.3050901@joh.to

Backpatch to 9.4, where pg_recvlogical was added.
src/bin/pg_basebackup/pg_recvlogical.c