Don't delay replication for less than recovery_min_apply_delay's resolution.
authorAndres Freund
Mon, 23 Mar 2015 15:40:10 +0000 (16:40 +0100)
committerAndres Freund
Mon, 23 Mar 2015 15:52:17 +0000 (16:52 +0100)
commit16be9737cc3d5f7da599a5c2fe2ff975db296f3b
tree0bb26604a9a28fd4013c4976fc9f2e884a237230
parent76d07a2a0633836a82c43beb8ed3b08a64dc3d46
Don't delay replication for less than recovery_min_apply_delay's resolution.

Recovery delays are implemented by waiting on a latch, and latches take
milliseconds as a parameter. The required amount of waiting was computed
using microsecond resolution though and the wait loop's abort condition
was checking the delay in microseconds as well.  This could lead to
short spurts of busy looping when the overall wait time was below a
millisecond, but above 0 microseconds.

Instead just formulate the wait loop's abort condition in millisecond
granularity as well. Given that that's recovery_min_apply_delay
resolution, it seems harmless to not wait for less than a millisecond.

Backpatch to 9.4 where recovery_min_apply_delay was introduced.

Discussion: 20150323141819[email protected]
src/backend/access/transam/xlog.c