Fix and simplify some code related to cryptohashes
authorMichael Paquier
Fri, 8 Jan 2021 01:37:03 +0000 (10:37 +0900)
committerMichael Paquier
Fri, 8 Jan 2021 01:37:03 +0000 (10:37 +0900)
commit15b824da97afb45f47e51b6b5b7e5eca09e5d03d
treefee8545abec7fa6075af0bb6c54382d74ccf8f43
parent9ffe2278372d7549547176c23564a5b3404d072e
Fix and simplify some code related to cryptohashes

This commit addresses two issues:
- In pgcrypto, MD5 computation called pg_cryptohash_{init,update,final}
without checking for the result status.
- Simplify pg_checksum_raw_context to use only one variable for all the
SHA2 options available in checksum manifests.

Reported-by: Heikki Linnakangas
Discussion: https://postgr.es/m/f62f26bb-47a5-8411-46e5-4350823e06a5@iki.fi
contrib/pgcrypto/internal.c
src/common/checksum_helper.c
src/include/common/checksum_helper.h