Fix "ignoring return value" complaints from commit 96d1f423f9
authorJoe Conway
Sat, 4 Jul 2020 17:47:31 +0000 (13:47 -0400)
committerJoe Conway
Sat, 4 Jul 2020 17:47:31 +0000 (13:47 -0400)
commit1243aa9b2f2e8a23f5fbace2b038b962bf79e9f0
treee977e269484706ab844c2b67e9c2f5d5291431d5
parentc2cdaf0cb912fa24ac56170c7c47a2fc398e2516
Fix "ignoring return value" complaints from commit 96d1f423f9

The cfbot and some BF animals are complaining about the previous
read_binary_file commit because of ignoring return value of ‘fread’.
So let's make everyone happy by testing the return value even though
not strictly needed.

Reported by Justin Pryzby, and suggested patch by Tom Lane. Backpatched
to v11 same as the previous commit.

Reported-By: Justin Pryzby
Reviewed-By: Tom Lane
Discussion: https://postgr.es/m/flat/969b8d82-5bb2-5fa8-4eb1-f0e685c5d736%40joeconway.com
Backpatch-through: 11
src/backend/utils/adt/genfile.c