Improve underdocumented btree_xlog_delete_get_latestRemovedXid() code.
authorTom Lane
Fri, 3 Aug 2012 19:41:23 +0000 (15:41 -0400)
committerTom Lane
Fri, 3 Aug 2012 19:41:23 +0000 (15:41 -0400)
commit11de73b25dbeea012ae61e8f1dcf939f6b737286
tree18acd3301bd559d8aa9b05d445e9afe8929d3b63
parentdd6947aae8cd05809f03c9aae1908f5c70f0dd7d
Improve underdocumented btree_xlog_delete_get_latestRemovedXid() code.

As noted by Noah Misch, btree_xlog_delete_get_latestRemovedXid is
critically dependent on the assumption that it's examining a consistent
state of the database.  This was undocumented though, so the
seemingly-unrelated check for no active HS sessions might be thought to be
merely an optional optimization.  Improve comments, and add an explicit
check of reachedConsistency just to be sure.

This function returns InvalidTransactionId (thereby killing all HS
transactions) in several cases that are not nearly unlikely enough for my
taste.  This commit doesn't attempt to fix those deficiencies, just
document them.

Back-patch to 9.2, not from any real functional need but just to keep the
branches more closely synced to simplify possible future back-patching.
src/backend/access/nbtree/nbtxlog.c