Avoid possibly-unsafe use of Windows' FormatMessage() function.
authorTom Lane
Tue, 29 Mar 2016 15:54:57 +0000 (11:54 -0400)
committerTom Lane
Tue, 29 Mar 2016 15:54:57 +0000 (11:54 -0400)
commit11cc7bb8825efc74c9418f6e88d448cc253c47b0
tree8046e4ed03a6b3bf5ca63952dc776231b17c225a
parenta3c643938166abed9a390cdbd8a5df09bfe39523
Avoid possibly-unsafe use of Windows' FormatMessage() function.

Whenever this function is used with the FORMAT_MESSAGE_FROM_SYSTEM flag,
it's good practice to include FORMAT_MESSAGE_IGNORE_INSERTS as well.
Otherwise, if the message contains any %n insertion markers, the function
will try to fetch argument strings to substitute --- which we are not
passing, possibly leading to a crash.  This is exactly analogous to the
rule about not giving printf() a format string you're not in control of.

Noted and patched by Christian Ullrich.
Back-patch to all supported branches.
src/backend/libpq/auth.c
src/backend/port/win32/socket.c
src/interfaces/libpq/fe-auth.c
src/port/dirmod.c